Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCAP-667] Add environment specific CCMS-API-configuration #1203

Merged

Conversation

enyia21
Copy link
Contributor

@enyia21 enyia21 commented Feb 25, 2025

🔗 Jira ticket

CCAP-667

✍️ Description

Add environment specific CCMS-API-Configuration

  • We are updating our environment configuration files to pass in CCMS creds
    - [ ] application-demo.yaml
    - [ ] application-dev.yaml
    - [ ] application-staging.yaml
    We are not updating application-production.yaml because do not have those credentials yet.
  • Each field has been added to Github secrets with the UAT credentials
  • dev should pass there credentials into there local environments

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

@github-actions github-actions bot requested a review from cram-cfa February 25, 2025 15:27
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-667-add-env-gh7jjt February 25, 2025 15:28 Inactive
@enyia21 enyia21 changed the title [CCAP-6678] Add environment specific CCMS-API-configuration [CCAP-667] Add environment specific CCMS-API-configuration Feb 25, 2025
@enyia21 enyia21 temporarily deployed to il-gcc-ccap-667-add-env-gh7jjt February 25, 2025 15:59 Inactive
Copy link
Contributor

@cram-cfa cram-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. I guess the worst case scenario is that @spokenbird (or whomever is using these values) needs to be sure that a null for anything in Production doesn't stop the application from working... and if things do not work with the values not set/null, then we could just set them to empty strings in Production until we have the real values.

@enyia21 enyia21 merged commit 1ed85c1 into main Feb 25, 2025
5 checks passed
@enyia21 enyia21 deleted the CCAP-667-Add-environment-specific-CCMS-API-configuration branch February 25, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants